Add JSON serialize functionality #25
Conversation
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/topo/model/GstTopoNode.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Outdated
Show resolved
Hide resolved
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
Formatting issues - I'd go with default eclipse conventions as probably that will be what most of plugin developers will use.
So you probably can solve of mentioned problems with ctrl shif f & ctrl shift o in eclipse.
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/topo/model/GstTopoGraph.java
Outdated
Show resolved
Hide resolved
edominia
force-pushed
the
serialize-json
branch
from
63b609d to
5a3728b
Compare
org.sofproject.alsa.topo/src/org/sofproject/alsa/topo/model/AlsaTopoGraph.java
Outdated
Show resolved
Hide resolved
org.sofproject.alsa.topo/src/org/sofproject/alsa/topo/model/AlsaTopoGraph.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Show resolved
Hide resolved
|
@edominia please also use a more descriptive commit message. You need to explain what, why and how for each patch. |
edominia
force-pushed
the
serialize-json
branch
3 times, most recently
from
400c344 to
4d84c46
Compare
org.sofproject.alsa.topo/src/org/sofproject/alsa/topo/model/AlsaTopoGraph.java
Show resolved
Hide resolved
|
Regarding jars that this PR adds f.e. - |
| gridLayout.verticalSpacing = 8; | ||
| shell.setLayout(gridLayout); | ||
|
|
||
| new Label(shell, SWT.NULL).setText("Name:"); |
There was a problem hiding this comment.
Name, description, and other properties collected here should be properties accessible via the ITopoGraph interface, displayed and editable in the Properties view. So that the serialize-to-json operation would not require any user interaction.
org.sofproject.gst.topo/src/org/sofproject/gst/json/JsonCustomOptionPane.java
Show resolved
Hide resolved
org.sofproject.topo.ui/src/org/sofproject/topo/ui/editor/policies/TopoEditorOnClickHandler.java
Show resolved
Hide resolved
org.sofproject.alsa.topo/src/org/sofproject/alsa/topo/model/AlsaTopoGraph.java
Outdated
Show resolved
Hide resolved
org.sofproject.alsa.topo/src/org/sofproject/alsa/topo/model/AlsaTopoGraph.java
Outdated
Show resolved
Hide resolved
| try { | ||
| ByteArrayOutputStream os = new ByteArrayOutputStream(); | ||
| Writer writer = new BufferedWriter(new OutputStreamWriter(os)); | ||
| tlvs.serialize(writer); |
There was a problem hiding this comment.
Do not duplicate the code of ITopoGraph.serialize(). Atm me may just refactor the latter to return a String and move target file content writing to topo.ui.
| .,\ | ||
| plugin.xml | ||
| plugin.xml,\ | ||
| lib/jackson-annotations-2.10.1.jar,\ |
There was a problem hiding this comment.
Do not import external binaries to the plug-in repository. Add a dependency to an existing Eclipse plug-in(s) to the manifest (and adjust the documentation if any of them is not a part of core bundle, see how the dependency on GEF is handled).
Jackson is on Apache license so I think it's ok. |
There was only possibility to serialize topology to gstreamer format. Added JSON serialize functionality. JSON format is is compatible with VAS. Signed-off-by: Emilia Dominiak <emilia.dominiak@intel.com>
edominia
force-pushed
the
serialize-json
branch
from
4d84c46 to
6ffdf8e
Compare
|
Merge three pull requests into one #43 |
5 participants
Signed-off-by: Emilia Dominiak emilia.dominiak@intel.com