Gstr cmd preferences #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajanusz
suggested changes
Jan 16, 2020
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
Please no merge commits like Merge remote-tracking branch ...
edominia
force-pushed
the
gstr_cmd_preferences
branch
2 times, most recently
from
0c3cea4 to
c98544f
Compare
jajanusz
reviewed
Jan 21, 2020
edominia
force-pushed
the
gstr_cmd_preferences
branch
from
c98544f to
dbd12a8
Compare
jajanusz
reviewed
Jan 21, 2020
org.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/wizards/GstNodeNewPage.java
Outdated
Show resolved
Hide resolved
Tabs and spaces were mixed. It provides consistent indentation. Signed-off-by: Emilia Dominiak emilia.dominiak@intel.com
edominia
force-pushed
the
gstr_cmd_preferences
branch
from
dbd12a8 to
fb59bd6
Compare
mmaka1
requested changes
Feb 5, 2020
org.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/wizards/GstNodeNewPage.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/GstCommandsPreferences.java
Outdated
Show resolved
Hide resolved
If there is a need to add more arguments to gstreamer default commands user has to add them to every new created project in proper wizard window. It improves user experience by creating a possiblity to set additional gstreamer commands in preferences window as they are common for all project and user doesn't need to repeat them every time during creating new project Signed-off-by: Emilia Dominiak <emilia.dominiak@intel.com>
edominia
force-pushed
the
gstr_cmd_preferences
branch
from
fb59bd6 to
b434118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27 Find better ways to include export paths into gstreamer commands