Connection preferences #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
reviewed
Jan 20, 2020
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Please remember and write a commit message for each commit and PR title. Otherwise reviewers have no clue what they are reviewing and history is useless.
edominia
force-pushed
the
conn_preferences
branch
from
0f15e78 to
06666c9
Compare
mmaka1
requested changes
Feb 5, 2020
org.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java
Outdated
Show resolved
Hide resolved
org.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java
Outdated
Show resolved
Hide resolved
| getFieldEditorParent()); | ||
| addField(ipFieldEditor); | ||
|
|
||
| userFieldEditor = new StringFieldEditor(ConnectionPreferencesConst.CONN_USERNAME, "Username for all projects: ", |
There was a problem hiding this comment.
"Last login name for Audio Dev projects: "?
Author
There was a problem hiding this comment.
We don't want use 'audio'. I will change it to Last login name for Dev projects.
|
|
||
| @Override | ||
| protected void createFieldEditors() { | ||
| ipFieldEditor = new StringFieldEditor(ConnectionPreferencesConst.CONN_ADDR, "Address for all projects: ", |
There was a problem hiding this comment.
Better to maintain a list of let's say 5 last entered addresses and populate a drop down box in the login dialog.
Author
There was a problem hiding this comment.
Ok, but let's make a new issue for it to create it later.
edominia
force-pushed
the
conn_preferences
branch
from
06666c9 to
7bfbe0d
Compare
User has to write node address and username for every project separately. It improves user experience by creating a possibility to set both in preferences windows so user doesn't have to repeat them for every project if they don't change. Signed-off-by: Emilia Dominiak <emilia.dominiak@intel.com>
edominia
force-pushed
the
conn_preferences
branch
from
7bfbe0d to
1308a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #35