Add convenience capability to initialize a dag directly from a dict. …#27
Open
gregnordin wants to merge 1 commit intothieman:masterfrom
Open
Add convenience capability to initialize a dag directly from a dict. …#27gregnordin wants to merge 1 commit intothieman:masterfrom
gregnordin wants to merge 1 commit intothieman:masterfrom
Conversation
…Add corresponding test
Author
|
Oh, and also--thanks for writing this package! I'm finding it to be quite useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Add corresponding test
I saw that add the pull request "add dict default arg to dag constructor #24" was never finished so I went ahead and did what you requested:
I think it should be all ready to accept from what I understand needed to be done.