Removed "register" as it is obsolete after C++11 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muanis
approved these changes
Apr 2, 2023
muanis
left a comment
muanis
left a comment
There was a problem hiding this comment.
Did the same and tested on my platformio.
|
Fast shipping, packaging excellent, do recommend! Would buy again! |
Collaborator
|
@thijse should we get this in? What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I am getting constant warnings from g++ from Arduino IDE v2, I'm nuking the now pointless "register" definitions. We are now compiling usually with C++17, or maybe C++11, both of which ignore (and whine about) register as a keyword.