Skip to content

Fix push-hf command in CLI#18

Draft
cmpatino wants to merge 4 commits intothinking-machines-lab:mainfrom
cmpatino:push-hf-cli
Draft

Fix push-hf command in CLI#18
cmpatino wants to merge 4 commits intothinking-machines-lab:mainfrom
cmpatino:push-hf-cli

Conversation

@cmpatino
Copy link

@cmpatino cmpatino commented Feb 3, 2026

This PR fixes two issues when using the push-hf command in the CLI:

  1. Fixes how we dealt with the checkpoint_complete file because the previous version conflicted with the Click CLI.
  2. The previous version required having the revision already available in the Hugging Face Hub. We now create the revision if it's not already available.

Comment on lines +536 to +537
checkpoint_complete_file = extract_dir / "checkpoint_complete"
checkpoint_complete_file.unlink(missing_ok=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checkpoint_complete_file = extract_dir / "checkpoint_complete"
checkpoint_complete_file.unlink(missing_ok=True)
checkpoint_complete.unlink(missing_ok=True)

@cmpatino cmpatino marked this pull request as draft February 3, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants