Skip to content

Comments

Remove face4#197

Open
brason wants to merge 34 commits intothreeDart:masterfrom
brason:remove_face4
Open

Remove face4#197
brason wants to merge 34 commits intothreeDart:masterfrom
brason:remove_face4

Conversation

@brason
Copy link

@brason brason commented Mar 30, 2015

This removes all use of Face4, replaces UV with Vector2, adds RingGeometry, as well as updates some examples and adds a new one.

extrude
geometries_2
shapes

@brason
Copy link
Author

brason commented Apr 7, 2015

/ping @johsin18 :)

@nelsonsilva
Copy link
Member

Thanks @brason
Looks like you did a lot of work ;)
Unfortunately I'd say there's too much going on for a single PR which makes it difficult to you review.
Can you break it down into smaller PRs with some more context info about the updates/new features (at least why they're something we want/need) ?
I'd say we're looking at at least four PRs: updates and cleanups, adding RingGeometry + samples, replacing UV with Vector 2 and removing Face4.
You can create a new branch from master, cherry pick some commits and push them to a new branch to open a new, smaller PR.

@brason
Copy link
Author

brason commented Apr 19, 2015

I feared you might say that :) I will get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants