Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #239 +/- ##
==========================================
+ Coverage 79.71% 79.84% +0.12%
==========================================
Files 47 47
Lines 5927 6123 +196
==========================================
+ Hits 4725 4889 +164
- Misses 1202 1234 +32 🚀 New features to boost your workflow:
|
Contributor
|
@PreisTo Is this PR ready for review or still draft? |
Contributor
Author
|
@ndilalla that's sadly still a draft - I am still going to need a couple of more days:/ |
Contributor
No worries at all! I asked because I saw that you requested my review and I wanted to make sure the PR was ready :-) |
… angular unit on initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- created aset_unitsfunction to manually set the units used in the analysis (must be called before creatingthreeMLandastromodelsobjects)Unitsdataclass to the config instead of hard-coding the default units