Fractional Time Component Representations#763
Closed
PacificBird wants to merge 1 commit intotime-rs:mainfrom
Closed
Fractional Time Component Representations#763PacificBird wants to merge 1 commit intotime-rs:mainfrom
PacificBird wants to merge 1 commit intotime-rs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=======================================
- Coverage 95.4% 95.1% -0.3%
=======================================
Files 95 95
Lines 9686 9718 +32
=======================================
+ Hits 9242 9244 +2
- Misses 444 474 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
What's the use case here? Off-hand, I feel like this is best represented by a |
Member
|
Closing due to lack of information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds helper methods on
Time,PrimitiveDateTime, andOffsetDateTimeto obtain fractional time component representations for hours, minutes, and seconds.For example,
time!(01:30:00.0000).fractional_hour() == 1.5,time!(01:30:30.0000).fractional_hour() == 30.5, and so on.