Skip to content

Updated pumping tests#54

Merged
mbakker7 merged 14 commits intotimflow-org:devfrom
HsHeesen:update-pumpingtest
Feb 25, 2026
Merged

Updated pumping tests#54
mbakker7 merged 14 commits intotimflow-org:devfrom
HsHeesen:update-pumpingtest

Conversation

@HsHeesen
Copy link

No description provided.

@mbakker7 mbakker7 changed the base branch from main to dev February 23, 2026 16:37
@mbakker7
Copy link
Contributor

Thanks for this PR. When updating the files, please submit notebooks without output and (if you can) run ruff.

@mbakker7
Copy link
Contributor

@dbrakenhoff could it be that these tests are failing because the testing environment uses a newer version of numpy?

@mbakker7 mbakker7 requested a review from dbrakenhoff February 23, 2026 17:55
@dbrakenhoff
Copy link
Contributor

@HsHeesen, @mbakker7 we can test this again once #56 is merged into dev and this branch is synchronized with dev. I can take of that when we get #56 sorted.

Copy link
Contributor

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! No comments on the implementation.

My only question is why timflow isn't able to reproduce some of the results obtained with Aqtesolve/MLU? I guess we sometimes calibrate to slightly different data, and if the RMSE is similar, I guess we've found another (local) minimum? So maybe not so surprising, but if that is the case we could mention that in the comment on the final results (which I think is already done for some, but I think not all)?

@mbakker7
Copy link
Contributor

Ready to go. Thanks for your PR.

@mbakker7 mbakker7 merged commit ebff9ae into timflow-org:dev Feb 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants