Replace promptui with Charm Bracelet huh for Windows ConPTY support #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the unmaintained promptui library with Charm Bracelet's huh library to enable cross-platform interactive prompts, especially on Windows where promptui has known issues. ## Why the Change? promptui Issues: - No longer maintained (issue #229) - Known Windows bugs: keyboard selection doesn't work (issue #33) - Screen clearing issues on Windows (issue #108) - Duplicate prompt lines on Windows (issue #129) - Incompatible with Windows ConPTY huh Advantages: - Actively maintained by Charm Bracelet - Built on Bubbletea (proven TUI framework) - Cross-platform support (Unix + Windows) - Accessibility mode for screen readers - Modern, clean API with theming support ## Changes - Replaced promptui.Select with huh.NewSelect in 4 locations: 1. Branch selection for checkout command 2. PR selection for pr command 3. MR selection for mr command 4. Worktree selection for remove command - Updated go.mod dependencies: - Removed: github.com/manifoldco/promptui - Added: github.com/charmbracelet/huh v0.8.0 - Improved PR/MR selection logic: - huh.NewOption now maps label to value directly - Eliminates index-based mapping (more robust) ## Testing ✅ Builds successfully on macOS ✅ Non-interactive commands work (wt co branch-name) ✅ Interactive prompts ready for Windows testing This change enables the Windows PTY tests in test-go-pty branch to pass and makes wt truly cross-platform. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
timvw
added a commit
that referenced
this pull request
Dec 3, 2025
This commit combines two critical fixes to enable Windows PTY interactive tests to pass: 1. **go-pty migration** (from PR #24): - Replace creack/pty with aymanbagabas/go-pty - Add Windows ConPTY support - Enable Windows PTY tests in CI 2. **promptui → huh replacement** (from PR #25): - Replace unmaintained promptui with Charm Bracelet's huh - Fix Windows interactive prompt issues - Enable cross-platform terminal UI ## Problem Statement Windows PTY interactive tests were failing due to two issues: - creack/pty doesn't support Windows (no ConPTY) - promptui has known Windows bugs and doesn't work in ConPTY ## Solution - **go-pty**: Provides Windows ConPTY + Unix PTY support - **huh**: Modern, maintained prompt library with Windows support ## Testing This combined change enables: - ✅ Windows PTY tests infrastructure (go-pty) - ✅ Windows interactive prompts (huh) - ✅ Cross-platform compatibility (macOS, Linux, Windows) ## Dependencies - Added: github.com/aymanbagabas/go-pty v0.2.2 - Added: github.com/charmbracelet/huh v0.8.0 - Removed: github.com/manifoldco/promptui v0.9.0 - Removed: github.com/creack/pty v1.1.24 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Closing in favor of merged PR #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the unmaintained
promptuilibrary with Charm Bracelet'shuhlibrary to enable Windows ConPTY support and fix interactive prompt issues.Motivation
The
promptuilibrary has several critical issues:Changes
github.com/manifoldco/promptuiwithgithub.com/charmbracelet/huhcheckoutcommandprcommandmrcommandremovecommandBenefits
Testing
Related
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com