feat(point): Round Point integerization to be a bit more natural#16
Merged
tirithen merged 1 commit intotirithen:mainfrom Mar 21, 2025
Merged
feat(point): Round Point integerization to be a bit more natural#16tirithen merged 1 commit intotirithen:mainfrom
Point integerization to be a bit more natural#16tirithen merged 1 commit intotirithen:mainfrom
Conversation
Without rounding, binary precision and truncation makes Point::<Centi>::new(2.05, 2.125) == (204, 212) With rounding, we get a more natural (205, 213).
tirithen
approved these changes
Mar 21, 2025
Owner
tirithen
left a comment
tirithen
left a comment
There was a problem hiding this comment.
This makes lots of sense, thank you for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for an excellent project. Are you open to using rounding rather than truncation when constructing points?
Without rounding, binary precision and truncation makes
Point::<Centi>::new(2.05, 2.125) == (204, 212)With rounding, we get a more natural
(205, 213).