Load from the unpacked section if we're in an ASAR archive #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjanczuk +1 on this. I'm facing an issue where the edge-cs dll can't be found because it's packed in an electron asar file. This fix will have no impact on other solutions. If 'app.asar' is not in the path, it will simply be ignored. @paulcbetts I submitted a pr to update your |
|
I have the same issue, any news on this ? |
Author
|
@dougludlow We're stuck on old edge-cs for other reasons, but I wouldn't be offended at all if you just stole this and submitted it yourself against current edge |
|
@tjanczuk, @paulcbetts, @tex0l - #9 created. |
|
I ended up just setting the EDGE_CS_NATIVE to point to the asar unpacked file... Didn't need this change after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron applications are often packed in a tarball-like format called ASAR, which resolves the path-too-long issues as well as saves on CreateFile calls. However, in order to load native DLLs, certain files are stored in the "unpacked" section, since Win32 obviously can't load DLLs out of ASAR archives - this PR allows you to load edge-cs out of an ASAR archive.