C++ and Python Bindings: re-raise kdl_v2 parse exception if kdl_v1 parse trial still fail#19
Open
C++ and Python Bindings: re-raise kdl_v2 parse exception if kdl_v1 parse trial still fail#19
Conversation
…ption from kdl_2 trial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is this library expect a v2 KDL document as input, but if parse fail, the library try to use v1 KDL spec to parse input document.
My idea is: if second attempt to parse document using v1 KDL spec still fails, re-throw exception found on first parse try (using v2 KDL spec) to show that this library prefer parsing v2 spec than v1