Conversation
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request re-adds the before support for
github.com/golang/mock/mockgennow as alternative supported tool for the newer and still maintainedgo.uber.org/mock/mockgen. The algorithm checks the localgo.modfile and installs the correspondingmockgen, currently not observing the installed version (which may be possible).The downside of this dynamic tool selection is, that it creates potential race conditions between concurrent
go-makeexecutions on different repositories using differentmockgens. This problem would be increased when adding the tool version itself.