Open
Conversation
mikolajpp
force-pushed
the
mp/groups-sub-lifecycle
branch
from
c751828 to
61d7e7e
Compare
channels: expose new scry endpoints, fix unit tests. groups: fix unit tests. group-ui: use new scry endpoints.
mikolajpp
commented
Dec 17, 2025
| :+ %group-update | -:!>(*vale:m-group-update) | ||
| :+ %group-log | -:!>(*vale:m-group-log) | ||
| :: | ||
| :+ %group-token & -:!>(*vale:m-group-token) |
Collaborator
Author
There was a problem hiding this comment.
This should not have been strict in the first place, because tokens are only transferred internally for now.
| [net group] | ||
| :_ group | ||
| ^- net:v10:gv | ||
| [%sub time init &+%done]:net |
Collaborator
Author
There was a problem hiding this comment.
Note that after type migration we are going to inflate our subscriptions, which will eventually adjust each connection status to its true state.
Fang-
reviewed
Dec 18, 2025
Member
Fang-
left a comment
Fang-
left a comment
There was a problem hiding this comment.
Didn't do channels/server line-by-line yet, but anything that I mentioned on groups should apply there as well.
Comments below!
Fang-
reviewed
Jan 7, 2026
Member
Fang-
left a comment
Fang-
left a comment
There was a problem hiding this comment.
Changes look good. We did spot some potential problem with channels' +ca-u-connection, let's reevaluate.
mikolajpp
force-pushed
the
mp/groups-sub-lifecycle
branch
from
9d6597c to
6760aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the subscription lifecycle mechanism in the groups and channels agents, tracking connection status on each main subscription. Using this mechanism, the group or channel host can signal a subscription problem without resorting to crashing. This will improve our error logs, as many problems that currently manifest as crashes will now be received as error facts, to be processed by the subscriber. Ultimately, this mechanism, or its elaboration, can be integrated in the UI to improve UX around resource connectivity.
Closes TLON-5136
Changes
%group-error,%channel-errorfacts send out on the offending subscription path.How did I test?
Tested connectivity logic in various two-party scenarios, involving resource deletion, banning, kicking, or lack of permissions.
Risks and impact
Rollback plan
This is both a state and protocol upgrade in groups and channels. To rollback, we will need to keep the new state and protocol versions, but carefully restore the original subscription logic. This will need to be done manually.