groups: expose /readers, /writers channel permissions scries#5469
Open
groups: expose /readers, /writers channel permissions scries#5469
Conversation
|
Can comment heavily in the code describing what each of these does so the bots can understand? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent experiments with bots revealed a need for a scry endpoint to return a set of ships with read of write permissions to a channel.
Changes
/groups/$group-id/channels/$channel-id/readersscry to return a set of ships with read permissions./groups/$group-id/writers/$channel-id/readersscry to return a set of ships with write permissions.How did I test?
Tested the scries in a group with two ships and a channel.
Risks and impact
Safe to rollback without consulting PR author? No, bots might lose access to some of their skills which depend on these endpoints.
Affects important code area:
Rollback plan
Revert.