Draft
Conversation
196378a to
1381419
Compare
981397e to
791656a
Compare
8231cec to
16eb79a
Compare
791656a to
5c187d9
Compare
5c187d9 to
6fccf34
Compare
1d11344 to
ffa95f9
Compare
6938acb to
aa4ce6d
Compare
1decd96 to
5a022e4
Compare
aa4ce6d to
2f18db1
Compare
afa6dd9 to
dcfe4be
Compare
efe1037 to
63cf3d8
Compare
dcfe4be to
4014a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standalone API follow-up on top of
db/api-move-onlyfocused on dependency-boundary cleanup, not product behavior changes.This PR makes
@tloncorp/apimore independently publishable by removing directshared/react-query/Expo coupling from the API package and enforcing boundaries in ESLint.Changes
@tloncorp/shareddependency/imports frompackages/api.react-queryexport/surface (queryClient/QueryClientProvider) and move consumers back to shared-owned react-query modules.expo-contacts,expo-localization) and shift contacts integration to app side via provider configuration.packages/api/src/**importing@tloncorp/shared*and../client*.apps/**importing internal@tloncorp/api/{client,api,lib,types/native}*entrypoints.lib/references,lib/branch).packages/api/package.json+ lockfile to reflect dependency removals.How did I test?
pnpm -r tscpnpm -r lintpnpm --filter @tloncorp/api lintDiff size
db/standalone-apivsorigin/develop:593 insertions,402 deletions(995 LOC churn)db/api-move-onlyvsorigin/develop:568 insertions,402 deletions(970 LOC churn)+25 LOCRisks and impact
Rollback plan
Screenshots / videos