profile: add gated public profile controls#5501
Open
jamesacklin wants to merge 8 commits intodevelopfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds public profile controls to the profile editor and wires them to
%profilevia pokes/scries. It also gates those controls behind a Tlon-only experimental feature flag.Changes
packages/shared/src/api/profileApi.tsand exported it frompackages/shared/src/api/index.ts.packages/app/ui/components/EditProfileScreenView.tsx:/profileon/off (start/suspend%profile, bind/unbind route).publicProfileControlsfeature flag inpackages/app/lib/featureFlags.ts(onlyTlon: true, default off).How did I test?
Flip the feature flag on if you are a Tlon employee
Visit the profile editor
Enable your public profile
Visit https://your-ship-url.com/profile
Confirm you see a page
Disable the public profile
Visit https://your-ship-url.com/profile
Confirm the page redirects
Re-enable the public profile
Flip various sections on and off
Refresh the public profile page
Confirm you see the sections appear and disappear
Risks and impact
%profilepoke/scry integrationRollback plan
EditProfileScreenViewno longer renders public profile controls.packages/shared/src/api/profileApi.tsexports/usages are removed by revert.Screenshots / videos