Open
Conversation
fanc999
force-pushed
the
master
branch
3 times, most recently
from
889f887 to
9d83bc6
Compare
thep
reviewed
Jan 19, 2021
Contributor
thep
left a comment
thep
left a comment
There was a problem hiding this comment.
How about replacing unlink() calls in main() with remove() from <stdio.h> and getting rid of <unistd.h> completely?
Open
* configure.ac:
* Makefile.am:
* win32/*:
- Support building libdatrie as a DLL with Visual Studio.
building trietool.exe and the tests are also supported.
Add detection logic for ARM64 builds, since we can support Windows 10+ on ARM64 with the appropriate Compiler/Linker flags.
Make sure that things are set apart from the 2019 builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This adds NMake build files to enable libdatrie to be buildable with Visual Studio 2008 and later in both 32-bit and 64-bit (x86-64) flavours,
Please note that one of the test programs is updated slightly not to include unistd.h on Windows. All the rest of the existing code are left untouched.
With blessings, thank you!