This repository was archived by the owner on Dec 23, 2024. It is now read-only.
begin genericizing this so that editing config won't show up in git changes#24
Open
justizin wants to merge 1 commit intotmclaugh:masterfrom
Open
begin genericizing this so that editing config won't show up in git changes#24justizin wants to merge 1 commit intotmclaugh:masterfrom
justizin wants to merge 1 commit intotmclaugh:masterfrom
Conversation
Owner
|
I'm struggling with this change and not sure what to do. I want to be able to pull this repo down anywhere and have my settings. I want people in other orgs to be able to do the same. I'm struggling with this issue right now because I forked this into my work organization and the work I've done there is totally mergeable back to here. The larger issue is it's hard to make site specific changes in general and still keep the forked repo mergeable back here. This includes spots like scripts/ and tests/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is exactly the path you want to take upstream, I'm just offering to help sort of make this more generic and usable for others like me who appreciate your work.
I'm not sure off-hand if there are any other environment-specific file contents outside of site.rb, but if so I considered a script that generates them from a .json.
An interesting default solution for site.rb might also be to allow these config values to be specified by environment variables, and to make everything work with no site.rb at all.
Creating this PR mostly for discussion sake, but feel free to merge it, it's a small change which includes a documentation change.