Skip to content

feat!: alternative units and ingredients #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmlmt merged 51 commits into from
Jan 13, 2026
Merged

feat!: alternative units and ingredients #80

tmlmt merged 51 commits into from
Jan 13, 2026

Conversation

@tmlmt
Copy link
Owner

@tmlmt tmlmt commented Jan 6, 2026 •
edited
Loading

Description

Introduction of alternative units and ingredients

Resolves: #66

Resolves: #69

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tmlmt Graphite App
Copy link
Owner Author

tmlmt commented Jan 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tmlmt tmlmt mentioned this pull request Jan 6, 2026
Closed
4 tasks
@tmlmt tmlmt changed the title define types, define regex feat: Jan 6, 2026
@tmlmt tmlmt changed the title feat: feat!: alternative units and ingredients Jan 6, 2026
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d8e738f to d24e9a0 Compare January 9, 2026 20:31
@tmlmt tmlmt mentioned this pull request Jan 9, 2026
Merged
4 tasks
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d24e9a0 to 78a9f15 Compare January 9, 2026 21:09
@tmlmt tmlmt changed the base branch from v3 to graphite-base/80 January 11, 2026 03:27
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from 78a9f15 to d4637e7 Compare January 11, 2026 03:27
@tmlmt tmlmt changed the base branch from graphite-base/80 to docs/multiversion January 11, 2026 03:27
This was referenced Jan 11, 2026
Merged
Merged
Merged
@tmlmt tmlmt changed the base branch from docs/multiversion to graphite-base/80 January 11, 2026 18:30
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d4637e7 to 1d2d5e5 Compare January 11, 2026 18:31
@tmlmt tmlmt changed the base branch from graphite-base/80 to ci/pre-release January 11, 2026 18:31
This was referenced Jan 11, 2026
Merged
Merged
@tmlmt tmlmt changed the base branch from ci/pre-release to graphite-base/80 January 13, 2026 14:18
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from 1f0ad37 to 06878b2 Compare January 13, 2026 14:18
@tmlmt tmlmt changed the base branch from graphite-base/80 to chore/human-regex-v2.2.0 January 13, 2026 14:18
@tmlmt tmlmt mentioned this pull request Jan 13, 2026
Merged
7 tasks
@tmlmt tmlmt force-pushed the chore/human-regex-v2.2.0 branch 2 times, most recently from 28e09cc to 4553261 Compare January 13, 2026 15:12
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from 06878b2 to 0a02d36 Compare January 13, 2026 15:12
@tmlmt tmlmt marked this pull request as ready for review January 13, 2026 15:16
tmlmt added 28 commits January 13, 2026 15:23
@tmlmt
chore: remove useless reference to __no-unit__
3d88fbf
@tmlmt
fix(sortUnitList): no-unit ranked higher than integer-protected units
f7e2156
@tmlmt
chore: ensure consistant sorting regardless of host locale
3180353
@tmlmt
test: add more tests for quantities/alternatives.ts
a0050c8
@tmlmt
fix(parsing): ingredient name and groupkey not detected for alternati…
1799306 
…ves with groupkey
@tmlmt
test(shoppingList): maximize coverge
d1ea21e
@tmlmt
fix(parsing): ingredient-recipe anchor for alternative ingredients wi…
05f19ba 
…th groupkey
@tmlmt
fix(parsing): alternatives of ingredient items should not contain itemId
92e0b86
@tmlmt
style(regex): remove leading @ from in-line ingredient alternatives
f6d269b
@tmlmt
chore: remove console.log
7f96641
@tmlmt
chore(parsing): do not expect a note for ingredient alternatives with…
b4a8bfb 
… group keys
@tmlmt
fix(parsing): alternative units not detected properly
b886930
@tmlmt
fix(Recipe): clone function missing choices property
2c545b3
@tmlmt
reach 100% coverage and fix issues along the way
9369f69
@tmlmt
feat(ProductCatalog): allow multiple product sizes
3c12f53
@tmlmt
chore: authorize parcel and vue-demi with approve-builds
f4ee806
@tmlmt
chore(Recipe): hide _itemCount from instance properties
bf6e588
@tmlmt
chore(gitignore): ignore .nuxt
4ccd2f8
@tmlmt
feat: show all options in ingredients list and enable calculating wit…
65d1ffb 
…h options
@tmlmt
docs: add missing types and fine-tune docstrings
594fe15
@tmlmt
fix: add alternative units to ingredients list
88649ea
@tmlmt
refactor: separate primary quantity from equivalents across the Recip…
39eb2ab 
…e object
@tmlmt
fix: capture alternative units of alternative ingredients, and avoid …
22d84c4 
…chained quantity property names
@tmlmt
fix: handle unit-less alternatives
8e3acf2
@tmlmt
fix: add equivalents and simplify ingredients too
d829a5c
@tmlmt
fix: main And groups of quantities that are added and simplified
c1c07bb
@tmlmt
fix: export new quantity types
a102817
@tmlmt
chore(test): fix parser_helpers tests wrt types
986c800
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from 0a02d36 to 986c800 Compare January 13, 2026 15:23
@tmlmt tmlmt merged commit 6f9f0e8 into v3 Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmlmt