Treat ids with double primes correctly (fixes #11)#12
Open
aztek wants to merge 2 commits intotmont:masterfrom
Open
Treat ids with double primes correctly (fixes #11)#12aztek wants to merge 2 commits intotmont:masterfrom
aztek wants to merge 2 commits intotmont:masterfrom
Conversation
Do not highlight identifiers with double primes as character literals in Haskell. The bug seems to be in an extra condition that checks if we are at the beginning of a character literal. The test file for Haskell looks fine after this change.
Owner
|
Cool! Can you provide a little haskell snippet containing a double prime that we can put in the test file? |
Extra code to test identifiers with single quotes in them. Only 'c' should be highlighted as a character literal, the rest are legal identifiers.
Author
|
This one should be enough. c :: Char
c = c'
where c' = c''
c'' = c'''
c''' = c'c'
c'c' = c'c''
c'c'' = c''c''
c''c'' = 'c'(Apparently, GitHub's syntax highlighter doesn't handle quotes wery well either.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not highlight identifiers with double primes as character literals in Haskell. The bug seems to be in an extra condition that checks if we are at the beginning of a character literal. The test file for Haskell looks fine after this change.