Skip to content

feat: add --version flag to root command #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobert wants to merge 1 commit into from
+26 −0
Closed

feat: add --version flag to root command #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions data_for_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,4 +1373,29 @@ var suites = []FixtureSuite{
},
},
},
// version flag tests
{
{
Name: "version subcommand",
Config: FixtureConfig{
CliArgs: []string{"version"},
},
Expect: Results{
CliOutput: "\n",
CliOutputRe: regexp.MustCompile(`\S+`),
ExitCode: 0,
},
},
{
Name: "--version flag",
Config: FixtureConfig{
CliArgs: []string{"--version"},
},
Expect: Results{
CliOutput: "\n",
CliOutputRe: regexp.MustCompile(`otel-cli version \S+`),
ExitCode: 0,
},
},
},
}
1 change: 1 addition & 0 deletions otelcli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func createRootCmd(config *Config) *cobra.Command {

cobra.EnableCommandSorting = false
rootCmd.Flags().SortFlags = false
rootCmd.Version = config.Version

Diag.NumArgs = len(os.Args) - 1
Diag.CliArgs = []string{}
Expand Down
Loading