feat: add --version flag to root command #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Users expect --version flag as standard CLI pattern (issue #9) Approach: Set rootCmd.Version in createRootCmd, add functional tests Learned: Cobra auto-adds -v/--version when Version field is set Next: Create PR and close issue Changes: - Added rootCmd.Version = config.Version in createRootCmd() - Added functional tests for both 'version' subcommand and '--version' flag - Tests verify output format and exit code - All tests pass Fixes #9 🤖 Claude <claude@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the standard --version flag (and -v short form) to otel-cli, complementing the existing version subcommand by setting Cobra's built-in version support.
Key changes:
- Enables Cobra's built-in
--versionflag by settingrootCmd.Version - Adds functional tests for both the
versionsubcommand and--versionflag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| otelcli/root.go | Sets rootCmd.Version to enable Cobra's built-in version flag support |
| data_for_test.go | Adds test cases for both version subcommand and --version flag functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Why: Need to validate version output format supports both 'unknown' and version strings Approach: Use CheckFuncs to validate output format while stripping variable content Learned: CheckFunc provides better validation than regex for variable content Next: Push and verify CI passes Changes: - Added strings import to data_for_test.go - Added CheckFunc for version subcommand to validate format - Added CheckFunc for --version flag to validate 'otel-cli version X' format - Both CheckFuncs handle 'unknown' or multi-part version strings - Use regex to strip content for checkOutput comparison 🤖 Claude <claude@anthropic.com>
Owner
Author
Test UpdateAdded proper version output validation using CheckFuncs: Why CheckFuncs?
What's validated:
How it works:
CI passing ✅ 🤖 Claude claude@anthropic.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
--versionflag (and-vshort form) to otel-cli, following standard CLI conventions.Changes
rootCmd.VersionincreateRootCmd()to enable Cobra's built-in version flagversionsubcommand and--versionflagTesting
Functional tests added:
otel-cli versionworks correctlyotel-cli --versionworks correctlyBoth test that:
Manual testing:
Related
Fixes #9
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com