Open
Conversation
- Adds llm and llm-openai as dependencies. - Refactors answer() and streaming_answer() to use llm.get_model() and model.chat() instead of openai.ChatCompletion. - Updates README, Dockerfile, and deploy_instructions() to reflect new dependencies, env var config (MODEL, API keys), and the continued need for OPENAI_API_KEY for embeddings.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the chat answer functions to use the new llm library and updates relevant dependencies and documentation to reflect the changes.
- Replaces OpenAI ChatCompletion with llm.get_model() and model.chat() in answer() and streaming_answer().
- Adds llm and llm-openai dependencies and updates deployment instructions and the README accordingly.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added new dependencies ("llm" and "llm-openai") to support chat models. |
| microllama/init.py | Refactored answer functions to leverage the llm library; removed openai.ChatCompletion. |
| README.md | Updated API key instructions and deployment notes to reflect the new changes. |
Files not reviewed (1)
- microllama/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
microllama/init.py:11
- The code uses inspect.cleandoc() in answer() and streaming_answer() but there's no import for the 'inspect' module. Please add 'import inspect' near the other import statements.
from typing import Optional, Union
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds llm and llm-openai as dependencies.
Refactors answer() and streaming_answer() to use llm.get_model() and model.chat() instead of openai.ChatCompletion.
Updates README, Dockerfile, and deploy_instructions() to reflect new dependencies, env var config (MODEL, API keys), and the continued need for OPENAI_API_KEY for embeddings.