Fix TypeError when computing p-values with missing categorical values #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
TypeErrorthat occurs when computing p-values for categorical variables containing missing values. The error arises because missing values are replaced with the string 'None', leading to mixed-type categories (e.g.intandstr) which cannot be sorted during internal processing (ref #161 and #160).Previously, the following code would raise
TypeError: '<' not supported between instances of 'str' and 'int':The fixes are:
handle_categorical_nulls()to convert entire columns to string before replacing nulls with 'None', avoiding mixed-type category issues.