Fix Phoenix project detection#352
Closed
J3RN wants to merge 3 commits intotonini:masterfrom
J3RN:phoenix-minor-mode-for-phx1.3
Closed
Fix Phoenix project detection#352J3RN wants to merge 3 commits intotonini:masterfrom J3RN:phoenix-minor-mode-for-phx1.3
J3RN wants to merge 3 commits intotonini:masterfrom
J3RN:phoenix-minor-mode-for-phx1.3
Conversation
The `web' directory is removed with phx1.3 and placed under lib/<app-name>_web instead. Also change phoenix.routes -> phx.routes
I changed the name of the `alchemist-app-name` to `alchemist-phoenix--app-name` to indicate that 1) It's part of the alchemist-phoenix functionality and 2) The function is "private" For the sake of testing (and I was having great trouble with that), I generated a dummy Phoenix project. This project is admittedly larger than the dummy_elixir fixture, and I'm open to alternate approaches to this.
|
This is great. I was just about to open a PR with the same fix. Great work! |
|
would love to see this merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spiritual successor to #321
From the original:
My changes:
I changed the name of the
alchemist-app-nametoalchemist-phoenix--app-nameto indicate that it'sFor the sake of testing (and I was having great trouble with that), I generated a dummy Phoenix project. This project is admittedly larger than the dummy_elixir fixture, and I'm open to alternate approaches to this. Both projects together are still smaller than the images 😄