Build binary wheels automatically for Windows using Appveyor#54
Open
codypiersall wants to merge 3 commits intotonysimpson:masterfrom
Open
Build binary wheels automatically for Windows using Appveyor#54codypiersall wants to merge 3 commits intotonysimpson:masterfrom
codypiersall wants to merge 3 commits intotonysimpson:masterfrom
Conversation
a8b48a2 to
ebb581e
Compare
Contributor
Author
Contributor
Author
|
Hey @tonysimpson, do you have any plans to merge this? It should help with Windows support, I think. The generated wheels can be uploaded to PyPI, so Windows users who don't have compilers will still be able to |
Owner
|
@codypiersall I merged this but I can't get the builds for Python27 x64 or Python34 x64 working - could you have a look at it - I've probably broken something. code is in master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for automatically building Windows wheels using Appveyor. It builds nanomsg using the 1.0.0 tag and builds the Python extension. It works for Python 2.7-3.5, but cannot build the 64-bit extension for Python 2.7 or Python 3.3 because Appveyor does not support the 64-bit version of the compiler needed for those Python versions. I had to make a couple small changes to make this work:
test_poll.py, change the test slightly that makes sure polling times out correctly. I think the only reason this was necessary was that the Appveyor node this was running on wasn't scheduling the process to run fast enough to get the timeout perfectly.You can see some jobs that ran on Appveyor. If you click on one of the jobs, you can see the build artifacts, which in this case is a wheel. If this PR is accepted and you set up an account with Appveyor, then wheels will be automatically generated and can be uploaded to PyPI so Windows users don't have to go through the steps of building support on their own.
Please let me know if you need me to do anything else in order to accept the PR!
Note that my template file for the appveyor.yml script came from the Python packaging website.