Skip to content

setup: Simplify build of abi3 wheels and add tests #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdarnell merged 3 commits into from
Oct 24, 2024
Merged

setup: Simplify build of abi3 wheels and add tests #3433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b22a0f
ci: Update macos version used for release builds
bdarnell Oct 23, 2024
fbbf126
ci: Run abi3audit on built wheels
bdarnell Oct 23, 2024
b690f4c
setup: Remove override of bdist_wheel
bdarnell Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2022, macos-12]
os: [ubuntu-22.04, windows-2022, macos-15]

steps:
- uses: actions/checkout@v4
Expand All @@ -64,6 +64,11 @@ jobs:
- name: Build wheels
uses: pypa/cibuildwheel@v2.18

- name: Audit ABI3 compliance
# This may be moved into cibuildwheel itself in the future. See
# https://github.com/pypa/cibuildwheel/issues/1342
run: "pip install abi3audit && abi3audit --verbose --summary ./wheelhouse/*.whl"

- uses: actions/upload-artifact@v4
with:
name: artifacts-${{ matrix.os }}
Expand Down
17 changes: 1 addition & 16 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
import platform
import setuptools

try:
import wheel.bdist_wheel
except ImportError:
wheel = None


kwargs = {}

Expand Down Expand Up @@ -56,17 +51,7 @@
)
]

if wheel is not None:
# From https://github.com/joerick/python-abi3-package-sample/blob/main/setup.py
class bdist_wheel_abi3(wheel.bdist_wheel.bdist_wheel):
def get_tag(self):
python, abi, plat = super().get_tag()

if python.startswith("cp"):
return "cp39", "abi3", plat
return python, abi, plat

kwargs["cmdclass"] = {"bdist_wheel": bdist_wheel_abi3}
kwargs["options"] = {"bdist_wheel": {"py_limited_api": "cp39"}}


setuptools.setup(
Expand Down