Skip to content

Revert no-bold button to fix issue of no buttons at all #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BergQuester wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Revert no-bold button to fix issue of no buttons at all #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4874221
Changing target from 7.0 to 6.0
Jul 21, 2014
f85c280
Bumping to 1.10.5
Jul 21, 2014
2adad05
Changing repo from tpalmer to gofullstack
Jul 21, 2014
209ac90
Bumping SDCAlertViewHLT from 1.5 to 1.51
Jul 21, 2014
6412001
Undoing last change
Jul 21, 2014
0b99783
Another tpalmer -> gofullstack change
Jul 21, 2014
0814d83
Revert no-bold button to fix issue of no buttons at all
Oct 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions iRate/iRate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,25 +813,12 @@ - (void)promptForRating
NSString *message = self.ratedAnyVersion? self.updateMessage: self.message;

#if TARGET_OS_IPHONE

id alert;
if (floor(NSFoundationVersionNumber) > NSFoundationVersionNumber_iOS_6_1) {
// iOS 7
alert = [[SDCAlertView alloc] initWithTitle:self.messageTitle
message:self.message
delegate:(id<UIAlertViewDelegate>)self
cancelButtonTitle:[self.cancelButtonLabel length] ? self.cancelButtonLabel: nil
otherButtonTitles:self.rateButtonLabel, nil];
[alert setDoNotBoldCancel:@YES];
}
else {
alert = [[UIAlertView alloc] initWithTitle:self.messageTitle
message:self.shortMessage
delegate:(id<UIAlertViewDelegate>)self
cancelButtonTitle:[self.cancelButtonLabel length] ? self.cancelButtonLabel: nil
otherButtonTitles:self.rateButtonLabel, nil];
}


UIAlertView *alert = [[UIAlertView alloc] initWithTitle:self.messageTitle
message:message
delegate:(id<UIAlertViewDelegate>)self
cancelButtonTitle:[self.cancelButtonLabel length] ? self.cancelButtonLabel: nil
otherButtonTitles:self.rateButtonLabel, nil];
if ([self.remindButtonLabel length])
{
[alert addButtonWithTitle:self.remindButtonLabel];
Expand Down
8 changes: 4 additions & 4 deletions iRateHLT.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Pod::Spec.new do |s|
s.name = 'iRateHLT'
s.version = '1.10.3'
s.version = '1.10.5'
s.license = 'zlib'
s.summary = 'A handy class that prompts users of your iPhone or Mac App Store app to rate your application after using it for a while.'
s.homepage = 'https://github.com/tpalmer/iRate'
s.homepage = 'https://github.com/gofullstack/iRate'
s.authors = 'Travis Palmer'
s.source = { :git => 'https://github.com/tpalmer/iRate.git', :tag => '1.10.3' }
s.source = { :git => 'https://github.com/gofullstack/iRate.git', :tag => '1.10.5' }
s.source_files = 'iRate/iRate.{h,m}'
s.resources = 'iRate/iRate.bundle'
s.requires_arc = true
s.ios.deployment_target = '7.0'
s.ios.deployment_target = '6.0'
s.osx.deployment_target = '10.6'
s.ios.dependency 'SDCAlertViewHLT'
end