Open
Conversation
* use custom process for evaluating phrases instead of using 'eval()' * added support for 'not', 'implies', 'xor', 'xand' etc * adding support for other operations is as simple as defining a lambda expression and adding some logic to the `group_operations` function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the Minor refactoring PR I also created, with the only new commit being the latest one. There's a lot of changes in the last commit but it's summarized in the commit message and I added a lot of comments in the file to. I've done quite a bit of testing and it seems to work for all the operations. Let me know what you think! I really like this project and the use of eval() but I wanted to make it more robust and I think it turned out well. Let me know if anything is confusing or if anything should be changed. I didn't change the README but that would have to be changed too.