Add ability to modify probe settings#35
Merged
tananaev merged 2 commits intotraccar:mainfrom Feb 22, 2026
Merged
Conversation
Member
|
Can you please rebase. |
Contributor
Author
|
Rebased. Thanks. |
rossigee
force-pushed
the
modify-probe-settings
branch
2 times, most recently
from
6e66ad6 to
e8ac319
Compare
- Add readiness and liveness probe configuration options - Allow customization of probe intervals, timeouts, and failure thresholds - Enhance deployment flexibility for different environments
rossigee
force-pushed
the
modify-probe-settings
branch
from
e8ac319 to
578dc70
Compare
Contributor
Author
|
@tananaev - is this still of interest? |
Member
|
We would need someone else to review this because I'm not really an expert. |
Contributor
Author
|
@tananaev - who would you expect to review this ? |
Member
|
Probably some other people who contributed here. |
Contributor
Author
Any people specifically? I see @filippolmt has commented/approved other previously merged PRs. |
Contributor
|
The processing seems correct to me. Move the logic to the values like this, so, if needed, you can directly modify the livenessProbe and readinessProbe. |
Contributor
Author
|
Worth merging ? |
Contributor
Author
|
If there's no interest, please let me know so I can close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the setting of custom probe values (refs #34).