feat: Front design system by GlennTractr · Pull Request #600 · tractr/traxion

GlennTractr · 2023-03-16T14:39:26Z

No description provided.

… email)

… components

… base component

…m component

…ue for date and datetime

…t component

… system

nx-cloud · 2023-03-16T14:39:30Z

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit cf0d94e.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

ThibautMTL · 2023-03-17T18:45:52Z

libs/angular/design-system/src/lib/base/base-form-control.component.ts

+    null,
+  );
+
+  @Input() id?: string = new Date().getTime().toString();


la variable ne sera jamais undefined si on l'initialise avec une valeur par défaut. On peut enlever l'opérateur '?'

Suggested change

@Input() id?: string = new Date().getTime().toString();

@Input() id: string = new Date().getTime().toString();

ThibautMTL · 2023-03-17T19:35:55Z

libs/angular/design-system/src/lib/select/select-multiple-ui/select-multiple-ui.component.html

+
+<div *ngIf="errors$ | async as errors">
+  <pre>
+This field is invalid


ne pas mettre de text hardcodé

ThibautMTL · 2023-03-17T19:40:29Z

libs/angular/design-system/src/lib/select/select-single-ui/select-single-ui.component.html

+  (blur)="onTouched()"
+  [disabled]="disabled"
+>
+  <option [value]="null">{{ placeholder || '' }}</option>


placeholder n'est pas déclarer

ThibautMTL · 2023-03-17T19:41:08Z

libs/angular/design-system/src/lib/select/select-single-ui/select-single-ui.component.html

+
+<div *ngIf="errors$ | async as errors">
+  <pre>
+This field is invalid


ne pas mettre de text hardcodé

ThibautMTL · 2023-03-17T19:41:56Z

libs/angular/design-system/src/lib/input/date-ui/input-date-ui.component.html

+
+<div *ngIf="errors$ | async as errors">
+  <pre>
+This field is invalid


ne pas mettre de text hardcodé

ThibautMTL · 2023-03-17T20:01:44Z

libs/angular/design-system/src/lib/input/text-ui/input-text-ui.component.ts

+  extends BaseInputTextComponent
+  implements OnInit
+{
+  @Input() placeholder?: string;


Suggested change

@Input() placeholder?: string;

@Input() placeholder: string = 'Text';

ThibautMTL · 2023-03-17T20:02:01Z

libs/angular/design-system/src/lib/input/text-ui/input-text-ui.component.html

+  #input
+  [id]="prefixId + id"
+  type="text"
+  [placeholder]="placeholder || ''"


Suggested change

[placeholder]="placeholder || ''"

[placeholder]="placeholder"

ThibautMTL · 2023-03-17T20:03:01Z

libs/angular/design-system/src/lib/input/textarea-ui/input-textarea-ui.component.ts

+{
+  @ViewChild('textarea') textarea!: ElementRef<HTMLTextAreaElement>;
+
+  @Input() placeholder?: string;


Suggested change

@Input() placeholder?: string;

@Input() placeholder: string = 'Textarea';

ThibautMTL · 2023-03-17T20:04:34Z

libs/angular/design-system/src/lib/input/textarea-ui/input-textarea-ui.component.html

+<textarea
+  #textarea
+  [id]="prefixId + id"
+  [placeholder]="placeholder || ''"


Suggested change

[placeholder]="placeholder || ''"

[placeholder]="placeholder"

ThibautMTL · 2023-03-17T20:05:22Z

libs/angular/design-system/src/lib/input/time-ui/input-time-ui.component.html

+  #input
+  [id]="prefixId + id"
+  type="time"
+  [placeholder]="placeholder"


placeholder n'est pas déclarer

GlennTractr added 30 commits February 17, 2023 12:53

feat(angular-design-system): add angular design system lib

c1f7a75

feat(angular-design-system): add storybook + button submit design system

1d77e06

feat(angular-design-system): move button submit on design system

9dde3a4

feat(angular-design-system): add input email design system

360cc3b

feat(angular-design-system): add input password in design system

148d8ee

feat(angular-design-system): add input text

2fcb3cf

test(angular-design-system): add unit test for input password

05bfed5

refactor(angular-design-system): harmonized input html

26b7227

test(angular-design-system): add unit test in text input(password and…

bf1b7ee

… email)

feat(angular-design-system): add input number design system

1fd57ec

test(angular-design-system): add unit test for value of input text

55757fa

feat(angular-design-system): add date input design system

385e00a

test(angular-design-system): improve storybook of password input

f2a2668

test(angular-design-system): add filling value story on design system…

a12b420

… components

refactor(angular-design-system): refacto base input component

3039722

feat(angular-design-system): add input datetime design system

68c9c97

refactor(angular-design-system): move format number from component to…

65abbda

… base component

feat(angular-design-system): return date for date and datetime component

c336d52

feat(angular-design-system): add time component design system

d7a909c

refactor(angular-design-system): refacto stories of time component

cceaf18

refactor(angular-design-system): refacto placeholder for design-syste…

8c5f11b

…m component

test(angular-design-system): add unit test to check bad formatted val…

ac23820

…ue for date and datetime

refactor(angular-design-system): remove base input number

4b45870

feat(angular-design-system): add textarea design system

2447f08

fix(angular-design-system): fix error on textarea template

44ba10c

test(angular-design-system): remove bad arguments of button ui

68f1a52

feat(angular-design-system): add single select design system

145e631

feat(angular-design-system): add selected observable for single selec…

9135ba5

…t component

refactor(angular-design-system): extract base select class for design…

290316f

… system

feat(angular-design-system): add select multiple design system

cf0d94e

GlennTractr requested a review from ThibautMTL March 16, 2023 14:39

ThibautMTL reviewed Mar 17, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Front design system#600

feat: Front design system#600
GlennTractr wants to merge 30 commits intomainfrom
STAK-710-front-design-system

GlennTractr commented Mar 16, 2023

Uh oh!

nx-cloud bot commented Mar 16, 2023 •

edited

Loading

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

ThibautMTL Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	@Input() id?: string = new Date().getTime().toString();
	@Input() id: string = new Date().getTime().toString();

	@Input() placeholder?: string;
	@Input() placeholder: string = 'Text';

	[placeholder]="placeholder \|\| ''"
	[placeholder]="placeholder"

	@Input() placeholder?: string;
	@Input() placeholder: string = 'Textarea';

Conversation

GlennTractr commented Mar 16, 2023

Uh oh!

nx-cloud bot commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nx-cloud bot commented Mar 16, 2023 •

edited

Loading