WIP - handle Leaflet.draw add/delete with R leaflet layerManger#98
Open
timelyportfolio wants to merge 2 commits intotrafficonese:masterfrom
Open
WIP - handle Leaflet.draw add/delete with R leaflet layerManger#98timelyportfolio wants to merge 2 commits intotrafficonese:masterfrom
timelyportfolio wants to merge 2 commits intotrafficonese:masterfrom
Conversation
Contributor
|
I need to review this but looks like a good starting point. I can get to this over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#96
Questions:
layerManageronly supports full removal with the key combination ofcategoryandlayerId. I used category asnullbut we could easily use something likedrawor even the same asgroup. ForlayerId, I just usedString(L.stamp(layer)). I would make pull to R leaflet for other removal methods, but I know that acceptance might be slow.layerIdto support removal of single layers? I know that a user could monitor the Leaflet.draw events in Shiny to keep a list, but is there an easier way.layerIdwas assigned.Code to demonstrate: