Skip to content

Expose raw validation results #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnd wants to merge 2 commits into
base: v2.3.0.rc2
Choose a base branch
from
Open

Expose raw validation results #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f69de8
return bool value from Result#failure?
dnd Aug 17, 2018
df4c5c5
expose raw validation results in Result
dnd Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/reform/result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ class Result
def initialize(results, nested_results = []) # DISCUSS: do we like this?
@results = results # native Result objects, e.g. `#<Dry::Validation::Result output={:title=>"Fallout", :composer=>nil} errors={}>`
@failure = (results + nested_results).find(&:failure?) # TODO: test nested.
@nested_results = nested_results
end

def failure?; @failure end
attr_reader :failure, :nested_results, :results

def failure?; !!@failure end # rubocop:disable Style/DoubleNegation

def success?; !failure? end

Expand Down
33 changes: 33 additions & 0 deletions test/validation/result_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,39 @@ def failure?; !success? end

# TODO: errors(args) not tested.

describe "Contract::Result#failure" do
let(:failed) { MyResult.new(false) }
let(:succeeded) { MyResult.new(true) }

it { Reform::Contract::Result.new([succeeded, failed]).failure.must_equal failed }
it { Reform::Contract::Result.new([succeeded, succeeded], [failed]).failure.must_equal failed }
end

describe "Contract::Result#failure?" do
let(:failed) { MyResult.new(false) }
let(:succeeded) { MyResult.new(true) }

it { Reform::Contract::Result.new([failed, failed]).failure?.must_equal true }
it { Reform::Contract::Result.new([succeeded, failed]).failure?.must_equal true }
it { Reform::Contract::Result.new([failed, succeeded]).failure?.must_equal true }
it { Reform::Contract::Result.new([succeeded, succeeded]).failure?.must_equal false }
end

describe "Contract::Result#nested_results" do
let(:failed) { MyResult.new(false) }
let(:nested) { MyResult.new(true) }

it { Reform::Contract::Result.new([failed], [nested]).nested_results.must_equal [nested] }
end

describe "Contract::Result#results" do
let(:failed) { MyResult.new(false) }
let(:succeeded) { MyResult.new(true) }

it { Reform::Contract::Result.new([succeeded, failed]).results.must_equal [succeeded, failed] }
it { Reform::Contract::Result.new([succeeded, succeeded], [failed]).results.must_equal [succeeded, succeeded] }
end

describe "Contract::Result#success?" do
let(:failed) { MyResult.new(false) }
let(:succeeded) { MyResult.new(true) }
Expand Down