Skip to content

Comments

Added function to generate vkey from skey#199

Merged
mhutchinson merged 2 commits intotransparency-dev:mainfrom
mhutchinson:vkeyfromskey
Jul 23, 2025
Merged

Added function to generate vkey from skey#199
mhutchinson merged 2 commits intotransparency-dev:mainfrom
mhutchinson:vkeyfromskey

Conversation

@mhutchinson
Copy link
Contributor

This is scoped only to Ed25519 keys. This comes up in many implementations where an operator wants to sign new messages, but also authenticate previous messages they may have made (e.g. witnesses, logs).

This is scoped only to Ed25519 keys. This comes up in many implementations where an operator wants to sign new messages, but also authenticate previous messages they may have made (e.g. witnesses, logs).
@mhutchinson mhutchinson requested a review from a team as a code owner July 23, 2025 08:47
@mhutchinson mhutchinson requested review from AlCutter and roger2hk July 23, 2025 08:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 37.14286% with 22 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (fa00c16) to head (bc7d6d9).
Report is 113 commits behind head on main.

Files with missing lines Patch % Lines
note/note_verifier.go 37.14% 15 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #199       +/-   ##
===========================================
- Coverage   82.57%   72.18%   -10.39%     
===========================================
  Files           5        6        +1     
  Lines         241      471      +230     
===========================================
+ Hits          199      340      +141     
- Misses         30       93       +63     
- Partials       12       38       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta

@mhutchinson mhutchinson merged commit be3b100 into transparency-dev:main Jul 23, 2025
8 checks passed
@mhutchinson mhutchinson deleted the vkeyfromskey branch July 23, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants