Skip to content

Stop reading unused id in assignEntries func #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roger2hk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop reading unused id in assignEntries func #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions storage/gcp/gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,13 +808,12 @@ func (s *spannerCoordinator) assignEntries(ctx context.Context, entries []*tesse

_, err := s.dbPool.ReadWriteTransaction(ctx, func(ctx context.Context, txn *spanner.ReadWriteTransaction) error {
// First we need to grab the next available sequence number from the SeqCoord table.
row, err := txn.ReadRowWithOptions(ctx, "SeqCoord", spanner.Key{0}, []string{"id", "next"}, &spanner.ReadOptions{LockHint: spannerpb.ReadRequest_LOCK_HINT_EXCLUSIVE})
row, err := txn.ReadRowWithOptions(ctx, "SeqCoord", spanner.Key{0}, []string{"next"}, &spanner.ReadOptions{LockHint: spannerpb.ReadRequest_LOCK_HINT_EXCLUSIVE})
if err != nil {
return fmt.Errorf("failed to read SeqCoord: %w", err)
}
var id int64
if err := row.Columns(&id, &next); err != nil {
return fmt.Errorf("failed to parse id column: %v", err)
if err := row.Columns(&next); err != nil {
return fmt.Errorf("failed to parse next column: %v", err)
}

// Check whether there are too many outstanding entries and we should apply
Expand Down
Loading