Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the "engines" field to package.json to explicitly declare which Node.js versions are supported by tree-sitter.
Installation failures can occur if users try to install the package on unsupported Node versions.
Why this change is suggested
During development, I ran into installation issues on Node 24:
This happens because:
Adding the "engines" field prevents users from accidentally attempting to install the package on unsupported Node versions and improves the visibility of required Node versions.
Repro Steps
masterbranch ofnode-tree-sitterTesting Versions
I manually tested the bounds for node versions by using the command:
with versions 16 through 24.
New behavior -- show warning on error
npm is now aware of the compatible node versions. Incompatible node versions will still fail to install the package, but the user now has a better understanding of what they can do to resolve the issue.
