Connect using SSID with prefix if on iOS >= 13#98
Open
saoron wants to merge 2 commits intotripflex:masterfrom
Open
Connect using SSID with prefix if on iOS >= 13#98saoron wants to merge 2 commits intotripflex:masterfrom
saoron wants to merge 2 commits intotripflex:masterfrom
Conversation
|
This looks nice !! This functionality would allow me to just pass the prefix of smartphone devices (which are the same) to the connect function and it will try to connect to a network with that prefix? What happens if there are multiple networks with this prefix? |
|
Your PR won't work. It will always return an error because the prefix SSID is not the SSID which you are connected to. Tested with my iot devices. Working as expected. |
|
You also need to modify (void)iOSConnectOpenNetwork:(CDVInvokedUrlCommand*)command |
Collaborator
|
Might als be better to use a second plugin call for it but migrate the connect without password into the connect call. -> connect and connectPrefix |
Owner
|
@digaus would you mind submitting a PR with the fixes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
iOS 13 introduced a new way to connect with an SSID prefix, this will automatically use the prefix method if on iOS 13