This repository was archived by the owner on Feb 9, 2024. It is now read-only.
allow locked and notify_audit as default fields#25
Open
astropuffin wants to merge 2 commits intotrueaccord:masterfrom
Open
allow locked and notify_audit as default fields#25astropuffin wants to merge 2 commits intotrueaccord:masterfrom
astropuffin wants to merge 2 commits intotrueaccord:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened:
AssertionError
What you expected to happen:
I expect to be able to set the following config in my config file (as per the example):
And I expect that default option to propagate to my rules
How to reproduce it (as minimally and precisely as possible):
Set the following in the top level config file (along with all your other settings).
run
dogpush -c config.yaml diffThis PR moves the defaults from the non-overwritable list to the overwritable list. I have tested that this works locally with the
diffarg, but not sure what other considerations this impacts.