Skip to content

allow longer keys #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
K-Dud merged 1 commit into from
Nov 14, 2024
Merged

allow longer keys #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend-vue/src/components/core/change-short-name/changeShortNameValidationSchema.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ describe("change short name validation rules", () => {
expect(success).toBeFalsy();
});

test("cannot exceed 16 characters", () => {
test("cannot exceed 50 characters", () => {
const validation = shortNameValidationSchema("", []);

const { success } = validation.safeParse("a".repeat(17));
const { success } = validation.safeParse("a".repeat(51));

expect(success).toBeFalsy();
});
Expand Down
4 changes: 2 additions & 2 deletions frontend-vue/src/components/core/change-short-name/changeShortNameValidationSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const shortNameValidationSchema = (currentShortName: string | undefined,
zod
.string()
.min(1)
.max(16)
.max(50)
.superRefine((arg: string, ctx: RefinementCtx) => {
isUniqueIn<Domain>(arg, ctx, {
in: domains.filter((d) => d.shortName !== currentShortName),
Expand Down Expand Up @@ -41,7 +41,7 @@ export const boundedContextShortNameValidationSchema = (boundedContexts: Bounded
zod
.string()
.min(1)
.max(16)
.max(50)
.refine((term: string) => !startsWithNumber(term), {
message: "Must not start with a number",
})
Expand Down
Loading