Open
Conversation
Author
|
@marissamarym @EndBug keen to have your eyes on this one :) |
EndBug
reviewed
May 13, 2025
Member
EndBug
left a comment
EndBug
left a comment
There was a problem hiding this comment.
Hi! Thanks for the PR!
I've just seen it: can you clarify a bit about the nesting?
| } | ||
|
|
||
| export function paragraph(text: RichText[]): Block { | ||
| export function paragraph(text: RichText[]): BlockWithoutChildren { |
Member
There was a problem hiding this comment.
Why this change?
Paragraphs allow for nested blocks don't they?
|
|
||
| export function toggle( | ||
| text: RichText[], | ||
| children: BlockWithoutChildren[] = [] |
Member
There was a problem hiding this comment.
Toggles can nest indefinitely, children should just be an array of nomral blocks
Member
There was a problem hiding this comment.
I understand that the issue is that in gfm it's just html, and you can't nest that? Is that correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Markdown toggles to be converted into Notion blocks.