Fix blockquotes to remove empty space at the begining of the quote#79
Open
jdelgadofrts wants to merge 1 commit intotryfabric:masterfrom
Open
Fix blockquotes to remove empty space at the begining of the quote#79jdelgadofrts wants to merge 1 commit intotryfabric:masterfrom
jdelgadofrts wants to merge 1 commit intotryfabric:masterfrom
Conversation
jdelgadofrts
force-pushed
the
fix-quotes
branch
2 times, most recently
from
9aea085 to
9d88f36
Compare
jdelgadofrts
force-pushed
the
fix-quotes
branch
from
9d88f36 to
9d3f414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix.
Currently, when a blockquote is created, the function does not pass any initial text which generates a "empty quote" initial line instead of starting the quote properly.
This can be easily addressed by checking if the first line is a
text, and taking that first line as the initial rich text. Then allowing all the children to be passed.If a quote is passed without an initial text, then it falls through to the normal case in which they are all taken as "children"