Fix JST PH footprint to generate correct number of pads#497
Open
BoozeLee wants to merge 1 commit intotscircuit:mainfrom
Open
Fix JST PH footprint to generate correct number of pads#497BoozeLee wants to merge 1 commit intotscircuit:mainfrom
BoozeLee wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Parse pin count from footprint string (e.g., jst_ph_4 → 4 pins) - Update generatePads() to dynamically create pads for PH variant - Add tests for jst_ph_4 and jst_ph_6 footprints Fixes tscircuit#495 Before: jst_ph_4 only generated 2 pads (hardcoded) After: jst_ph_4 correctly generates 4 pads Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Author
|
Hi @seveibar! 👋 This PR fixes the bug reported in #495 where JST PH The fix:
Would it be possible to add a bounty to #495? This Thanks for maintaining such a great project! |
Author
|
Following up on the inquiry regarding a bounty for issue #495. This PR (labeled 'Bounty claim') is open. Please advise on the bounty status or next steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495
Before: jst_ph_4 only generated 2 pads (hardcoded)
After: jst_ph_4 correctly generates 4 pads
/claim #495