make direction optional in portProps schema#600
Open
shehaban wants to merge 12 commits intotscircuit:mainfrom
Open
make direction optional in portProps schema#600shehaban wants to merge 12 commits intotscircuit:mainfrom
shehaban wants to merge 12 commits intotscircuit:mainfrom
Conversation
Contributor
Author
|
@seveibar I’m working on the core to use portProps from the props instead of defining it inside the core. It was previously defined as optional in corePortProps. |
Contributor
|
Why does it need to be optional? Why not make required |
Contributor
Author
|
Because making it required will break existing tests, around 300 snapshot tests will fail |
Contributor
Nothing will break it's a required property. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎯 Why this change is needed
directionfield is already optional in the coreportProps.portPropsfrom@tscircuit/propsinstead of declaring it inside core.