Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
isI2cSda/isSpiMiso/isSpiSckwith a single typed set of capability values to simplify typing and runtime validation.Description
PinAttributeMapwith three new fields:capabilities?: Array<...>,activeCapabilities?: Array<...>, andactiveCapability?: ...inlib/common/layout.tsusing the enum values"i2c_sda","i2c_scl","spi_cs","spi_sck","spi_mosi","spi_miso","uart_tx","uart_rx".pinAttributeMapto validate the newcapabilities,activeCapabilities, andactiveCapabilityfields with constrainedz.enumvalues.tests/pinAttributes2.test.tsandtests/chip3-type-tests.test.tsx) so runtime parsing and type-level checks exercise the new model.generated/COMPONENT_TYPES.md,generated/PROPS_OVERVIEW.md) so docs reflect the newPinAttributeMapshape and ran formatting to keep repository consistent.Testing
bun scripts/generate-component-types.ts,bun scripts/generate-manual-edits-docs.ts,bun scripts/generate-readme-docs.ts, andbun scripts/generate-props-overview.tsand updated generated outputs.bun test tests/pinAttributes2.test.ts tests/chip3-type-tests.test.tsxand observed all tests passing (6 pass, 0 fail).bunx tsc --noEmitwhich completed without errors.bun run formatand re-ranbun testto confirm tests still pass after formatting.Codex Task