Draft
Conversation
jschlenger
added
enhancement
pjanck
reviewed
Apr 15, 2021
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
I think this is definitely the correct start.
Comment on lines
+1809
to
+1816
| void OpenInfraPlatform::UserInterface::MainWindow::on_actionShow_Ifc_Tree_triggered() { | ||
| if (ifcTreeDialog_ == nullptr) { | ||
| ifcTreeDialog_ = new IfcTreeDialog(this); | ||
| } | ||
|
|
||
| ifcTreeDialog_->show(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
How do you know which model was clicked?
pjanck
reviewed
Apr 22, 2021
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
Not all comments need addressing - if I'm wrong, merely resolve them.
This was referenced Apr 27, 2021
Closed
pjanck
reviewed
Jun 5, 2021
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
I'm still surprised that this ain't working ...
| ((QDialog*)this)->show(); | ||
| if (std::dynamic_pointer_cast<oip::IfcModel>(model)) | ||
| { | ||
| auto ifcModel = std::static_pointer_cast<OpenInfraPlatform::Core::IfcGeometryConverter::IfcModel>(model); |
Contributor
There was a problem hiding this comment.
use dynamic pointer cast as well
pjanck
reviewed
Jul 1, 2021
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
Note: Lots of commented out code, should be addressed before the final merge.
Collaborator
Author
|
Current status: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of a viewer that shows the hierarchy tree of IFC files.