[WIP] UT "sectional-solid-horizontal"#468
Draft
Elvira2227 wants to merge 3 commits intotumcms:developmentfrom
Draft
[WIP] UT "sectional-solid-horizontal"#468Elvira2227 wants to merge 3 commits intotumcms:developmentfrom
Elvira2227 wants to merge 3 commits intotumcms:developmentfrom
Conversation
Contributor
|
This definitely looks interesting. I see multiple separate issues that can be addressed:
Note: to screen shot just the active window, use |
pjanck
reviewed
Aug 23, 2021
Contributor
pjanck
left a comment
There was a problem hiding this comment.
I see that the file is 4x1, so there can be no IfcAxis2PlacementLinear - disregard that comment.
Check for existence of IfcSectionedSolidHorizontal in the unit test code.
Collaborator
Author
jschlenger
reviewed
Nov 11, 2021
Collaborator
jschlenger
left a comment
There was a problem hiding this comment.
Where did we conclude here? Were there mistakes in the Ifc file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added new unit test "sectional-solid-horizontal" to check #463. Fixes #463 .
Redid analysis as in this issue in usBIM.viewer (on the left side of the screenshot) and OIP (on the right).

The former does not read the deck and railings.
OIP reads all the parts, but with wrong orientations and the rails are in incorrect shape.
Work in progress