IfcSeventhOrderPolynomialSpiral#552
Merged
jschlenger merged 7 commits intotumcms:developmentfrom Aug 18, 2022
Merged
Conversation
Elvira2227
added
the
IFC
6 tasks
pjanck
approved these changes
Jul 19, 2022
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
I assume that unit tests work correctly.
Collaborator
|
Is just the unit test not working properly? |
Collaborator
|
Can you create an issue to check for the correctness of IfcSeventhOrderPolynomialSpiral with an example file? |
5 tasks
pjanck
approved these changes
Aug 11, 2022
Contributor
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
lftm
Is there an issue/PR with the unit tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request I implemented functions for reading the
IfcThirdOrderPolynomialSpiral.Now we can implement "VienneseBend curve" and this pull request can be addressed to issue #524.
In the CurveConverter.h I added:
getPointOnCurve()getDirectionOfCurve()convertIfcCurveSegment()During visualisation, there is an error in the unit test data #478.